Refactor e2e tests setup #491
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
📦 Size Report
|
oskarvu
force-pushed
the
yivlad/refactor-e2e-tests-setup
branch
from
671ec06 to
9925a48
Compare
packages/app/src/features/farm-details/dialogs/claim/e2e/mainnet/ClaimSKY.test-e2e.ts
Outdated
Show resolved
Hide resolved
yivlad
force-pushed
the
yivlad/refactor-e2e-tests-setup
branch
from
a287b2c to
a875f16
Compare
oskarvu
force-pushed
the
yivlad/refactor-e2e-tests-setup
branch
from
a875f16 to
902574f
Compare
packages/app/src/test/e2e/setup.ts
Outdated
| progressSimulationAndMine: ProgressSimulation | ||
| } | ||
|
|
||
| export type TestContext<T extends ConnectionType> = (T extends 'not-connected' ? {} : { account: Address }) & { |
There was a problem hiding this comment.
IMO i would make account optional here and simplify this type 🤷 . Generics are kinda PITA to pass around and this type is used in PageObjects etc.
There was a problem hiding this comment.
It's kinda convenient that if you need an address you don't have to make an assertion. What about making T equal not-connected by default? As in here 53a3a24
There was a problem hiding this comment.
It's kinda convenient that if you need an address you don't have to make an assertion.
But you need to make sure to pass appropriate generic type, no? Doesn't it result in some hard cast? or some other "unsafenest"? But I defer to your opinion here because you actually used this type xD
Closes FRO-1189